Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for send_join with unverifiable auth events #216

Merged
merged 3 commits into from
Oct 26, 2021

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Oct 22, 2021

Test the behaviour when we send a send_join response with unverifiable auth
events

Test the behaviour when we send a `send_join` response with unverifiable auth
events
@richvdh
Copy link
Member Author

richvdh commented Oct 22, 2021

see matrix-org/synapse#11012, on which this depends.

... to allow blacklisting for dendrite
richvdh added a commit to matrix-org/synapse that referenced this pull request Oct 25, 2021
This is the final piece of the jigsaw for #9595. As with other changes before this one (eg #10771), we need to make sure that we auth the auth events in the right order, and actually check that their predecessors haven't been rejected.

To do this I've reused the existing code we use when persisting outliers elsewhere.

I've removed the code for attempting to fetch missing auth_events - the events should have been present in the send_join response, so the likely reason they are missing is that we couldn't verify them, so requesting them again is unlikely to help. Instead, we simply drop any state which relies on those auth events, as we do at a backwards-extremity. See also matrix-org/complement#216 for a test for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants